Skip to content
Snippets Groups Projects
  1. Jun 10, 2023
  2. Jun 09, 2023
  3. Jun 07, 2023
    • Jonathan Schöbel's avatar
      fixup! Attr: changed semantics of (internal) move method · 054edb99
      Jonathan Schöbel authored
      While it should not be the case, that the Attr's internal method free's
      the passed attribute, as some of the other internal methods pass
      non-allocated pointers to it, the methods visible by the user should
      indeed free things, where the ownership of every inner element is
      already transfered. This was adjusted now. As some tests have taken
      advantage of the fact, that while not to be changed, the old pointers
      were still accessible, they had to be adjusted.
      054edb99
    • Jonathan Schöbel's avatar
      improved demo program · e161f370
      Jonathan Schöbel authored
      The demo program now uses some of the new functionality.
      e161f370
    • Jonathan Schöbel's avatar
      NodeFragment: changed semantics of insert_attr_new · 75d83bf1
      Jonathan Schöbel authored
      When there are methods in the api/abi, that take pointers to strings to
      store them in the library, there are two methods to do so. Either they
      are copying the string and leaving it intact, or they directly assign
      the given pointer to some internal storage. While the former method, is
      safer in terms of memory, as the user doesn't have to remember that he
      can't use the string anymore, the latter can be more efficient, as there
      is no extra strdup call, but the user is not allowed to change the
      pointer, free it and also can't use the pointer, because it can't be
      known whether it is already freed by the library. As it should be
      decideable by the user, the library often implements both approaches,
      where the method, that directly store pointers without creating a copy
      contains the raw_ prefix.
      
      The insert_attr_new methods were somewhat confusing in this regard, as
      it is likely to be expected, that they were copying the string, while in
      fact they did not. This is now fixed. The insert_attr_new methods copy
      the strings, while the added insert_attr_raw_new methods preserve the
      old behaviour of the insert_attr_new methods, thus allowing to let the
      user choose, what is more appropriate.
      75d83bf1
  4. Jun 06, 2023
  5. Jun 05, 2023
  6. Jun 04, 2023
    • Jonathan Schöbel's avatar
      NodeFragment: added remove_attr methods · 76e06eec
      Jonathan Schöbel authored
      Two alternatives are provided: remove_attr and pop_attr. While the
      former free's the Attr's data, the latter allocates a new Attr, to store
      and return the data. Both functionality is provided by a single
      (internal) static method.
      76e06eec
  7. Jun 03, 2023
  8. Jun 02, 2023
    • Jonathan Schöbel's avatar
      NodeFragment: added tests for get_attr method. · e8deb8ce
      Jonathan Schöbel authored
      added tests for getter
      e8deb8ce
    • Jonathan Schöbel's avatar
      fixup! Attr: (internal) added move method · 51a3ab66
      Jonathan Schöbel authored
      This is a severe bug. The purpose of Attr_free is to free the internal
      data, while leaving the outer structure unfreed. What is needed here is
      quite the opposite: freeing the outer structure but leaving the internal
      data intact. Of course the internal data is still needed, as it is data
      that was just assigned to the dest Attr. This bug introduced a double
      free, which is undefined behaviour with all of it's scary effects.
      51a3ab66
    • Jonathan Schöbel's avatar
      Attr: added is_equal_name method · 1eb4c294
      Jonathan Schöbel authored
      Sometimes it is interesting to know, whether to Attr are referring to
      the same attribute. Note that it is not intended to provide a method for
      the values, as that would be meaningless on its own and if it is used in
      a more complex tasks, this is still possible with the current set of
      methods, which is prefered as the complex task can then be implemented
      on the outside completely.
      1eb4c294
    • Jonathan Schöbel's avatar
      Attr: added is_equal method · 86d926c5
      Jonathan Schöbel authored
      A method to compare two Attr's for exact equality was added both to
      internal and external methods.
      86d926c5
  9. Jun 01, 2023
    • Jonathan Schöbel's avatar
      NodeFragment: added insert_copy methods for attributes · 7ccc8bee
      Jonathan Schöbel authored
      Sometimes you want to reuse an Attr after adding it, this is done via
      the insert_copy methods.
      7ccc8bee
    • Jonathan Schöbel's avatar
      fixup! NodeFragment: added remove methods · c747392d
      Jonathan Schöbel authored
      When a child is removed, the array may be reallocated, to not waste
      unused memory. If the child is removed out of the middle, all subsequent
      childs have to be moved. However, if it turns out that the reallocation
      is not currently possible, the method should return the NodeFragment in
      a state, as if the call to the remove method never happened. This means,
      that all the childs, that were moved before the realloc call, have to be
      moved back and the original child has also to be written back. This was
      forgotten, which is clearly a bug, which is fixed hereby.
      Note that it would be theoretically possible to not move everything back
      and forth, by storing the last value before the call to realloc and only
      in case of success move everything. While this is possible and more
      efficient, it is also a bit more complicated, and as this only takes
      effect, if the OS fails to provide memory, which should be an uncommon
      event, the algorithm is not changed, leaving that possible inefficient
      approach.
      c747392d
    • Jonathan Schöbel's avatar
      NodeFragment: added getter & insert methods for attributes · 13ac85b5
      Jonathan Schöbel authored
      The method SH_NodeFragment_get_attr provides a pointer to an Attr, by
      its index. Note, that it directly points to the internal data, instead
      of copying the data to a new Attr, which would be unneccessary overhead,
      if only reading access is needed. That's why it is also a const pointer.
      If the user intends to modify it, a copy should be taken via
      SH_Attr_copy.
      
      Multiple insert methods allow either to add an existing Attr, or to
      create a new one implicitly. If the Attr is not already used beforehand,
      it is more efficient to call the attr_new methods. Also an old Attr is
      freed, after it was inserted, thus it can't be used afterwards. This is
      neccessary, as for efficiency reasons an array of Attr is used directly,
      instead of the indirect approach of storing a pointer of Attr. This
      means, that the contents of the Attr has to be copied to the internal
      structure. If the old Attr would be left unfreed, there would be two
      Attrs, the original one and the implicit one, referring to the same
      data, which would lead to at least data corruption, or undefined
      behaviour like a double free, which would be a serious threat for a
      library which is to be used on a webserver. ...
      For each of the two insert modes, there is a method to prepend, append
      or insert at a specific position. An incorrect position is handled
      inside of the external method and an E_VALUE is thrown. The internal
      method doesn't handle this, so special care must be taken to not make
      undefined behaviour. However enforcing this check would be unneccessary
      overhead for the prepend and append methods, which are known to have
      correct indicies, as well for other internal methods, where the internal
      method may be used.
      
      The tests for the new methods are still missing, as well as the methods
      to remove an Attr. As the implementation is already a bit dated, the
      changes are commited now anyways.
      13ac85b5
  10. Mar 20, 2023
  11. Mar 17, 2023
Loading