Skip to content
Snippets Groups Projects
Commit 2b0343f5 authored by Sander, Oliver's avatar Sander, Oliver
Browse files

Fix minor bugs in productmanifold.hh

In particular:
* Forward declaring ProductManifold in the `impl` namespace
  is not a good idea.
* Add missing headers

targetspacetest.cc is extended to test for the first issue.
parent b5a361b9
Branches
No related tags found
No related merge requests found
Pipeline #11369 failed
......@@ -10,9 +10,14 @@
#include <dune/common/tuplevector.hh>
#include <dune/gfe/linearalgebra.hh>
#include <dune/gfe/symmetricmatrix.hh>
#include <dune/gfe/tensor3.hh>
namespace Dune::GFE
{
template <typename ... TargetSpaces>
class ProductManifold;
namespace Impl
{
template<typename T, typename ... Ts>
......@@ -24,9 +29,6 @@ namespace Dune::GFE
return T::convexityRadius;
}
template <typename TS, typename ... TargetSpaces>
class ProductManifold;
template<class U,typename Tfirst,typename ... TargetSpaces2>
struct rebindHelper
{
......
......@@ -370,6 +370,11 @@ void test()
}
// Test whether we can rebind to another number type
using FTargetSpace = typename TargetSpace::template rebind<float>::other;
// Can we construct an object of that rebound type?
FTargetSpace fTargetSpace;
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment