Skip to content
Snippets Groups Projects
  1. Feb 18, 2020
    • Sander, Oliver's avatar
      Always use shared_ptr from std:: namespace explicitly · 7cbe0451
      Sander, Oliver authored
      Up until dune-common 2.7, the Dune namespace contained shared_ptr:
      First as an actual implementation, later simply as a namespace
      import.  Dune-common post-2.7 has removed that import,
      and users of shared_ptr really have to explicitly specify
      the std:: namespace prefix.
      7cbe0451
  2. Feb 11, 2020
    • Sander, Oliver's avatar
      Avoid undefined behavior (sanitizer warning) · 46f6addc
      Sander, Oliver authored
      The svd code contains some index trickery, because the original code
      was written in fortran, which numbers arrays starting from '1'
      rather than from '0'.  This trickery included having a pointer point
      1 int in front of an allocated array, implicitly relying on the
      fact that pointer[0] would never be called.  The llvm sanitizer
      complains nevertheless, so this patch improves the trickery a little
      to avoid the objected pointer.
      46f6addc
    • Sander, Oliver's avatar
      Avoid leaking a LocalGeodesicFEFDStiffness object · b721f7bd
      Sander, Oliver authored
      Do this by making RodAssembler more similar to the generic
      GeodesicFEAssembler: the constructor argument is now a
      general LocalGeodesicFEStiffness, and not something particular
      to rod problems.
      b721f7bd
  3. Jan 29, 2020
  4. Jan 19, 2020
    • Sander, Oliver's avatar
      Delete the class GlobalGFETestFunction · 18b28b45
      Sander, Oliver authored
      I wrote it without a clear idea of what is needed of such a
      test function, and I never finished it.  Now it is unclear
      what the code does or is supposed to do, so let's just
      remove it.
      18b28b45
  5. Dec 18, 2019
  6. Oct 22, 2019
  7. Oct 11, 2019
    • Sander, Oliver's avatar
      harmonicenergytest.cc: Only test with points that are mutually close · 6c2eda51
      Sander, Oliver authored
      Previously, this test used a situation with geodesic interpolation
      between two points on the sphere that are almost antipodal.
      This made the TargetSpaceRiemannianTRSolver crash, because the
      weighted sum of squared distances can have indefinite second
      derivatives in such a situation.  In principle, the
      TargetSpaceRiemannianTRSolver should handle this, but nowadays
      it is not actually a TR solver anymore, but a plain local
      Newton method.  Maybe I should revert back to trust-region.
      
      I added a comment to targetspacetrsolver.cc that explains the
      situation a little.
      6c2eda51
  8. Oct 10, 2019
    • Sander, Oliver's avatar
      Improve documentation · f5d46bc9
      Sander, Oliver authored
      f5d46bc9
    • Sander, Oliver's avatar
      Fix GramSchmidtSolver · 917fe5b9
      Sander, Oliver authored
      The computation of the A-orthogonal matrices was wrong,
      and for some reason nobody ever really noticed this.
      One reason could be that in GFE applications A is frequently
      very close to the identity, and then you wouldn't notice
      the bug that much.
      
      Anyway, localgeodesicfefunctiontest.cc passes now.
      917fe5b9
  9. Oct 08, 2019
  10. Oct 07, 2019
  11. Jul 09, 2019
  12. Jun 23, 2019
  13. Jun 16, 2019
    • Sander, Oliver's avatar
      Introduce a base class for local energies · c250302c
      Sander, Oliver authored
      Currently, all implementations of variational problems inherit
      from LocalGeodesicFEStiffness, which requires gradient and Hessian
      implementations.  However, most of these implementations really
      only implement the energy, and leave computations of first and
      second derivatives to algorithmic differentiation.  To make
      this clearer, this patch introduces an abstract base class
      LocalEnergy for all implementations that really only have
      an energy.
      c250302c
  14. Jun 14, 2019
Loading